[tests/tools] Introduce ggma_run#16270
Merged
hseok-oh merged 1 commit intoSamsung:masterfrom Nov 6, 2025
Merged
Conversation
glistening
commented
Nov 5, 2025
Comment on lines
+24
to
+32
| #define NNPR_ENSURE_STATUS(a) \ | ||
| do \ | ||
| { \ | ||
| if ((a) != NNFW_STATUS_NO_ERROR) \ | ||
| { \ | ||
| exit(-1); \ | ||
| } \ | ||
| } while (0) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Beyond this PR. (Just for recording)
The NNPR_ENSURE_STATUS definition appears in several files:
- runtime/tests/tools/ggma_run/src/ggma_run.cc
- runtime/tests/tools/onert_run/src/nnfw_util.h
- runtime/tests/tools/onert_train/src/nnfw_util.h
- runtime/tests/custom_op/FillFrom/FillFrom_runner.cc
- runtime/contrib/style_transfer_app/src/style_transfer_app.cc
This is why I tried to define GGMA_ENSURE in ggma_macro.h. To minimize the expose API, however, we could follow the suggestion in #16260 and place it under test/tools/libs instead.
glistening
commented
Nov 5, 2025
| option(BUILD_XNNPACK "Build XNNPACK" OFF) | ||
|
|
||
| option(BUILD_GGMA_API "Build GGMA API for Generative AI" OFF) | ||
| option(BUILD_GGMA_RUN "Build ggma_run test driver" OFF) |
Contributor
Author
There was a problem hiding this comment.
Reviewers, I will turn BUILD_GGMA_API and BUILD_GGMA_RUN on after sentencepiece is handled for Tizen.
glistening
force-pushed
the
ggma_run___
branch
3 times, most recently
from
20bdd26 to
f30aa73
Compare
It adds ggma_run tools which uses GGMA api to generate text from given prompt. ONE-DCO-1.0-Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
glistening
force-pushed
the
ggma_run___
branch
from
f30aa73 to
573e411
Compare
Contributor
|
@chunseoklee is out of office until 11/13 |
This was referenced Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It adds ggma_run tools which uses GGMA api to generate text from given prompt.
ONE-DCO-1.0-Signed-off-by: Sanggyu Lee sg5.lee@samsung.com